affeq: optimize sparse affeq join#1773
Merged
Merged
Conversation
DrMichaelPetter
added
in progress
performance
Collaborator
Author
|
Next step is the evaluation, whether the changes are sound, and how much this impacts the performance, by running this on SVCOMP. |
Collaborator
Author
|
First tests look rather promising - next up is the svcomp run. |
Collaborator
Author
|
SV Comp shows no wrong verdicts, this is looking good. |
michael-schwarz
approved these changes
Jul 3, 2025
Member
michael-schwarz
left a comment
michael-schwarz
left a comment
There was a problem hiding this comment.
I did not really investigate the algorithm, but just left some code style remarks.
One big beautiful commit Co-authored-by: Michael Schwarz <michael.schwarz93@gmail.com>
sim642
added a commit
that referenced
this pull request
Jul 8, 2025
sim642
added a commit
that referenced
this pull request
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following #1625 , we can optimize the sparse affeq join even more: During join, we have several occasions where our implementation insists on accessing vectors via
nth. By cleverly rewriting the the procedure for disjunction of linear equalities, we can get rid of the harmful instances of this, hopefully making affine equalities an even more viable domain.